Bug 76667

Summary: Turn on CSS Filters on Windows
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: Layout and RenderingAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, jberlin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77673    
Bug Blocks:    
Attachments:
Description Flags
Patch adele: review+

Chris Marrin
Reported 2012-01-19 15:02:49 PST
Need to turn on CSS Filters (software path) on Windows
Attachments
Patch (4.92 KB, patch)
2012-02-02 09:40 PST, Chris Marrin 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2012-01-19 15:05:44 PST
InRadar <rdar://problem/10609286>
Chris Marrin
Comment 2 2012-02-02 09:40:36 PST
Created attachment 125149 [details] Patch
Chris Marrin
Comment 3 2012-02-02 09:58:59 PST
Committed r106566: <http://trac.webkit.org/changeset/106566>
Andy Estes
Comment 5 2012-02-02 12:57:10 PST
(In reply to comment #4) > This broke the Windows build: > > http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/45220/steps/compile-webkit/logs/stdio Looking.
Andy Estes
Comment 6 2012-02-02 13:13:00 PST
Rolled out in <http://trac.webkit.org/changeset/106586>. Reopening.
Andy Estes
Comment 7 2012-02-02 14:15:27 PST
The problem is that the build system (at least the Windows build system) isn't smart enough to re-process CSSPropertyNames.in when preprocessor macros change. I'm going to re-land Chris's patch with a whitespace-only change to CSSPropertyNames.in, which should force the bots to re-generate CSSPropertyNames.h.
Andy Estes
Comment 8 2012-02-02 14:50:54 PST
Committed r106593: <http://trac.webkit.org/changeset/106593>
Note You need to log in before you can comment on or make changes to this bug.