Bug 76662
| Summary: | DumpRenderTree and WebKitTestRunner should support --timeout option | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aroben, cmarcelo, darin, dpranke, efidler, eric, jesus, morrita, mxie, schenney, shinyak, skyul |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 78146 | ||
| Bug Blocks: | |||
Ryosuke Niwa
As Dirk and I discussed on IRC, we should have --timeout <timeout> option in each port's DRT.
This will allow DRT to gracefully timeout instead of webkit.py detecting the timeout and restarting DRT.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
Note that this does not replace the timer in webkit.py; we still need that to protect against a failing DRT (as we see on Chromium, which doesn't have the timer in chromium.py; see bug 74039).
A partial motivation for this is that since the non-chromium DRTs have hard-coded watchdog timers, long --time-out-ms values don't work correctly. That's bad.
This will also allow us to clean up the no_timeout parameter added to the Driver interface in bug 76612.