Summary: | CaseFoldingHash::hash() doesn't handle 8 bit strings directly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Michael Saboff
2012-01-19 11:46:15 PST
Created attachment 123205 [details]
Patch
Comment on attachment 123205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review r=me, just one little thing: > Source/JavaScriptCore/wtf/text/StringHash.h:105 > return hash(str->characters(), str->length()); You should switch this to characters16() to avoid the extra is8Bit() check in StringImpl::characters(). (In reply to comment #2) > (From update of attachment 123205 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review > > r=me, just one little thing: > > > Source/JavaScriptCore/wtf/text/StringHash.h:105 > > return hash(str->characters(), str->length()); > > You should switch this to characters16() to avoid the extra is8Bit() check in StringImpl::characters(). Thanks for catching that. I'll make the change before checking in. Committed r106260: <http://trac.webkit.org/changeset/106260> |