Bug 76650

Summary: check-webkit-style whitespace/operators triggers on overloaded division operator
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Tools / TestsAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, ojan, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2012-01-19 11:40:36 PST
+ inline float operator*(const float a, const AppUnit& b) Source/WebCore/platform/AppUnit.h:330: Missing spaces around / [whitespace/operators] [3] The whitespace/operators check triggers on declaration of overloaded operators. It should probably by modified to special case operators immediately preceded by the keyword operator. See bug 76571 for an example.
Attachments
Patch (2.30 KB, patch)
2012-01-23 15:45 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-01-23 15:42:34 PST
This only happens for the division operator, all other ones seems fine.
Emil A Eklund
Comment 2 2012-01-23 15:45:23 PST
Created attachment 123640 [details] Patch
Emil A Eklund
Comment 3 2012-01-23 16:01:26 PST
Comment on attachment 123640 [details] Patch Clearing flags on attachment: 123640 Committed r105652: <http://trac.webkit.org/changeset/105652>
Emil A Eklund
Comment 4 2012-01-23 16:01:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.