Bug 76649

Summary: Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: CSSAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Michael Saboff
Reported 2012-01-19 11:39:12 PST
Dromaeo tests cause parseSimpleLengthValue() on 8 bit strings to be converted to 16 bit strings. This routine should have an 8 bit path.
Attachments
Patch (5.12 KB, patch)
2012-01-19 14:52 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-01-19 14:52:55 PST
Created attachment 123203 [details] Patch Added 8 bit path.
Geoffrey Garen
Comment 2 2012-01-19 15:56:41 PST
Comment on attachment 123203 [details] Patch For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary.
Michael Saboff
Comment 3 2012-01-30 10:28:19 PST
(In reply to comment #2) > (From update of attachment 123203 [details]) > For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary. We still need the appropriate character pointer to call charactersToDouble().
Michael Saboff
Comment 4 2012-01-30 10:30:49 PST
Committed r106254: <http://trac.webkit.org/changeset/106254>
Note You need to log in before you can comment on or make changes to this bug.