Bug 76649

Summary: Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: CSSAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

Description Michael Saboff 2012-01-19 11:39:12 PST
Dromaeo tests cause parseSimpleLengthValue() on 8 bit strings to be converted to 16 bit strings.  This routine should have an 8 bit path.
Comment 1 Michael Saboff 2012-01-19 14:52:55 PST
Created attachment 123203 [details]
Patch

Added 8 bit path.
Comment 2 Geoffrey Garen 2012-01-19 15:56:41 PST
Comment on attachment 123203 [details]
Patch

For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary.
Comment 3 Michael Saboff 2012-01-30 10:28:19 PST
(In reply to comment #2)
> (From update of attachment 123203 [details])
> For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary.

We still need the appropriate character pointer to call charactersToDouble().
Comment 4 Michael Saboff 2012-01-30 10:30:49 PST
Committed r106254: <http://trac.webkit.org/changeset/106254>