Bug 76645

Summary:

Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ggaren: review+

Description Michael Saboff 2012-01-19 11:14:02 PST

Many of the dromaeo tests end up using StringImpl::find() and ::reverseFind() including the IgnoreCase varieties.  These methods don't have 8 bit string paths.

Comment 1 Michael Saboff 2012-01-19 11:58:26 PST

Created attachment 123163 [details]
Patch

This appears to be neutral to slightly positive to sun spider  and v8 performance.

Comment 2 Geoffrey Garen 2012-01-19 15:59:10 PST

Comment on attachment 123163 [details]
Patch

I think you should factor out the shared hash-search code into a static helper function template, to avoid code duplication.

Comment 3 Michael Saboff 2012-01-26 11:24:11 PST

Committed r106019: <http://trac.webkit.org/changeset/106019>