|Summary:||[chromium] Replace WGC3D visibility extension with resource_usage extension. [Part 1 of 3]|
|Product:||WebKit||Reporter:||Michal Mocny <mmocny>|
|Component:||New Bugs||Assignee:||Michal Mocny <mmocny>|
|Severity:||Normal||CC:||backer, fishd, kbr, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Michal Mocny 2012-01-19 07:28:56 PST
[chromium] Replace WGC3D visibility extension with resource_usage extension. [Part 1 of 3]
Comment 2 WebKit Review Bot 2012-01-19 07:33:50 PST
Please wait for approval from email@example.com before submitting because this patch contains changes to the Chromium public API.
Comment 3 Michal Mocny 2012-01-19 07:39:52 PST
Part2 (chromium side patch) is here: http://codereview.chromium.org/9192014/ Ken, I was hoping you could take a look here, especially at the location I added the ResourceUsage enum.
Comment 4 Kenneth Russell 2012-01-19 10:30:08 PST
Comment on attachment 123125 [details] Patch Looks fine. In general, Chromium extensions added to WebGraphicsContext3D should be mirrored in src/third_party/khronos/GLES2/gl2ext.h, and follow those API conventions (meaning that OpenGL enum values would need to be assigned, rather than using a local enum). However, since this is an API that is only executed on the client side and isn't mirrored in the GL API, the structure here is fine. r=me
Comment 5 WebKit Review Bot 2012-01-19 10:58:35 PST
Comment on attachment 123125 [details] Patch Rejecting attachment 123125 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11300150
Comment 7 Kenneth Russell 2012-01-19 11:09:52 PST
Comment on attachment 123151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123151&action=review > Source/WebKit/chromium/ChangeLog:6 > + Reviewed by Kenneth Russell. Just leave the "Reviewed by NOBODY (OOPS!)" line alone in the future. The commit queue will fill it in automatically.
Comment 8 Kenneth Russell 2012-01-19 11:10:29 PST
Comment on attachment 123151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123151&action=review > Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h:154 > + // TODO(mmocny): remove visibility once chromium patch lands I neglected to point out that WebKit uses FIXME comments rather than TODOs.
Comment 9 WebKit Review Bot 2012-01-19 16:29:45 PST
Comment on attachment 123151 [details] Patch Clearing flags on attachment: 123151 Committed r105462: <http://trac.webkit.org/changeset/105462>
Comment 10 WebKit Review Bot 2012-01-19 16:29:50 PST
All reviewed patches have been landed. Closing bug.