Bug 76625

Summary: Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Kinuko Yasuda <kinuko>
Status: RESOLVED FIXED    
Severity: Normal CC: ericu, jianli, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kinuko Yasuda
Reported 2012-01-19 05:14:54 PST
Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline. Many of the constant variables defined there are following chrome's coding style (like kFoo). (Leftover from issue 76551)
Attachments
Patch (10.85 KB, patch)
2012-01-19 05:31 PST, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2012-01-19 05:31:02 PST
Created attachment 123114 [details] Patch
Kinuko Yasuda
Comment 2 2012-01-19 05:55:03 PST
Mechanical changes only.
David Levin
Comment 3 2012-01-19 09:53:26 PST
Comment on attachment 123114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123114&action=review > Source/WebCore/platform/AsyncFileSystem.cpp:94 > +bool AsyncFileSystem::isAvailable() Why did this get added?
Eric U.
Comment 4 2012-01-19 11:27:07 PST
Comment on attachment 123114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123114&action=review >> Source/WebCore/platform/AsyncFileSystem.cpp:94 >> +bool AsyncFileSystem::isAvailable() > > Why did this get added? Looks like it came from line 67 above.
David Levin
Comment 5 2012-01-19 11:33:13 PST
Comment on attachment 123114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123114&action=review >>> Source/WebCore/platform/AsyncFileSystem.cpp:94 >>> +bool AsyncFileSystem::isAvailable() >> >> Why did this get added? > > Looks like it came from line 67 above. Thanks.
WebKit Review Bot
Comment 6 2012-01-19 22:39:36 PST
Comment on attachment 123114 [details] Patch Clearing flags on attachment: 123114 Committed r105483: <http://trac.webkit.org/changeset/105483>
WebKit Review Bot
Comment 7 2012-01-19 22:39:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.