Bug 76616

Summary: [GTK] Add print-backgrounds setting to WebKit2 GTK+ API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 75544    
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2012-01-19 03:14:34 PST
To allow disabling print brackgrounds.
Attachments
Patch (7.25 KB, patch)
2012-01-19 03:16 PST, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-01-19 03:16:51 PST
Created attachment 123093 [details] Patch
WebKit Review Bot
Comment 2 2012-01-19 03:20:05 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2012-01-19 09:05:31 PST
Comment on attachment 123093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123093&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:761 > + * Whether background images should be printed. Oh, you should probably be more explicit here that this happens only during printing runs.
Carlos Garcia Campos
Comment 4 2012-01-19 09:31:15 PST
Committed r105417: <http://trac.webkit.org/changeset/105417>
Note You need to log in before you can comment on or make changes to this bug.