Bug 76573

Summary:

Make WebAudio API const-correct.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Web Audio

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

crogers, dbates, dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

74553

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	dbates: review+, webkit.review.bot: commit-queue-

Jer Noble

Reported 2012-01-18 14:24:28 PST

Make WebAudio API const-correct.

Attachments
Patch (45.02 KB, patch) 2012-01-18 14:40 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (63.55 KB, patch) 2012-01-18 15:39 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (65.39 KB, patch) 2012-01-18 16:39 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (66.14 KB, patch) 2012-01-18 20:45 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (67.43 KB, patch) 2012-01-18 21:47 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (68.28 KB, patch) 2012-01-19 10:23 PST, Jer Noble	dbates: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2012-01-18 14:40:21 PST

Created attachment 122999 [details] Patch

Chris Rogers

Comment 2 2012-01-18 14:54:14 PST

Looks fine to me, assuming the bots pass.

WebKit Review Bot

Comment 3 2012-01-18 15:30:01 PST

Comment on attachment 122999 [details] Patch Attachment 122999 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11282375

Jer Noble

Comment 4 2012-01-18 15:30:36 PST

Whoops, forgot to modify the platform-specific implementations.

Jer Noble

Comment 5 2012-01-18 15:39:31 PST

Created attachment 123022 [details] Patch Made platform-specific implementations match their platform-neutral declarations. Found more functions which needed const-correcting.

WebKit Review Bot

Comment 6 2012-01-18 16:17:28 PST

Comment on attachment 123022 [details] Patch Attachment 123022 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11284397

Jer Noble

Comment 7 2012-01-18 16:39:20 PST

Created attachment 123035 [details] Patch Yet more platform-specific fixes.

WebKit Review Bot

Comment 8 2012-01-18 17:28:54 PST

Comment on attachment 123035 [details] Patch Attachment 123035 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11284444

Jer Noble

Comment 9 2012-01-18 20:45:59 PST

Created attachment 123063 [details] Patch Ditto.

WebKit Review Bot

Comment 10 2012-01-18 21:11:47 PST

Comment on attachment 123063 [details] Patch Attachment 123063 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11211912

Jer Noble

Comment 11 2012-01-18 21:47:51 PST

Created attachment 123070 [details] Patch Double ditto.

WebKit Review Bot

Comment 12 2012-01-18 22:47:17 PST

Comment on attachment 123070 [details] Patch Attachment 123070 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11300014

Jer Noble

Comment 13 2012-01-19 10:23:44 PST

Created attachment 123147 [details] Patch Another day, another platform-specific compile error.

Daniel Bates

Comment 14 2012-01-19 10:58:26 PST

Comment on attachment 123147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123147&action=review > Source/WebCore/platform/audio/SincResampler.cpp:139 > + // FIXME: find a way to make the following const-correct: Nit: "find" => "Find". You may want to consider filling a WebKit bug for this so as to make it actionable.

Jer Noble

Comment 15 2012-01-19 11:05:11 PST

(In reply to comment #14) > (From update of attachment 123147 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123147&action=review > > > Source/WebCore/platform/audio/SincResampler.cpp:139 > > + // FIXME: find a way to make the following const-correct: > > Nit: "find" => "Find". > > You may want to consider filling a WebKit bug for this so as to make it actionable. Will do. Thanks!

WebKit Review Bot

Comment 16 2012-01-19 11:09:01 PST

Comment on attachment 123147 [details] Patch Attachment 123147 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11253559 New failing tests: fullscreen/full-screen-iframe-zIndex.html

Jer Noble

Comment 17 2012-01-19 11:13:48 PST

(In reply to comment #16) > (From update of attachment 123147 [details]) > Attachment 123147 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11253559 > > New failing tests: > fullscreen/full-screen-iframe-zIndex.html Whoops, that test snuck into my patch. I'll excise it before committing.

Jer Noble

Comment 18 2012-01-19 12:01:27 PST

Committed r105431: <http://trac.webkit.org/changeset/105431>

Jer Noble

Comment 19 2012-01-19 12:03:42 PST

In the end, SincResampler::consumeSource did not need to take a const parameter (as it was a convenience function which operates on a mutable buffer), so its change (and thus the FIXME) were unnecessary.

Note You need to log in before you can comment on or make changes to this bug.