Bug 76568

Summary: HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading
Product: WebKit Reporter: Victoria Kirst <vrk>
Component: New BugsAssignee: Victoria Kirst <vrk>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Victoria Kirst
Reported 2012-01-18 13:59:04 PST
HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading
Attachments
Patch (4.02 KB, patch)
2012-01-18 14:02 PST, Victoria Kirst 		no flags
DetailsFormatted DiffDiff
Patch (4.15 KB, patch)
2012-01-18 15:50 PST, Victoria Kirst 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Victoria Kirst
Comment 1 2012-01-18 14:02:11 PST
Created attachment 122987 [details] Patch
Eric Carlson
Comment 2 2012-01-18 14:43:44 PST
Comment on attachment 122987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122987&action=review > Source/WebCore/ChangeLog:12 > + No new tests. (OOPS!) "(OOPS!)" will cause the patch to be rejected by the commit-hook. Please add an explanation of why there are no new tests. > Source/WebCore/html/HTMLMediaElement.cpp:1300 > +void HTMLMediaElement::setNetworkStateFromLoadingToIdle() Nit: I think a better name would be "changeNetworkStateFromLoadingToIdle"
Victoria Kirst
Comment 3 2012-01-18 15:50:15 PST
Created attachment 123025 [details] Patch
Victoria Kirst
Comment 4 2012-01-18 15:50:42 PST
Thanks for the speedy review, Eric! Updated patch with your suggestions.
Victoria Kirst
Comment 5 2012-01-18 17:19:55 PST
Committed r105365: <http://trac.webkit.org/changeset/105365>
Note You need to log in before you can comment on or make changes to this bug.