Bug 76500 – IndexedDB: Check for permission before using IndexedDB from a worker.

• Component: New Bugs
• Status: RESOLVED FIXED

[David Grogan]

IndexedDB: Check for permission before using IndexedDB from a worker.

[David Grogan]

Created attachment 122848 [details]
Patch

[David Grogan]

Dave Levin - could you review?

This patch has updated parts of https://bugs.webkit.org/show_bug.cgi?id=73609 that I had pulled out.  There are some comments in the code explaining why I think this is thread-safe, but the WebCore::AllowCrossThreadAccess call still feels gross.

[David Levin]

Comment on attachment 122848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122848&action=review

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:115
> +            m_webWorkerClientImpl->postTaskForModeToWorkerContext(

No new line needed here but if you add one then you need {} for this.

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:136
> +          bridge->signalCompleted(false, mode);

indentation isn't correct.

[David Grogan]

Created attachment 122978 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 122978 [details]
Patch for landing

Clearing flags on attachment: 122978

Committed r105324: <http://trac.webkit.org/changeset/105324>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.