Bug 76499

Summary: [EFL] Use static const insted of #define macro.
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-01-17 17:04:26 PST
WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro. This patch replace global variables defined by #define with const. const keyword can make very slight performance hit. I think we can ignore it.
Attachments
Patch (11.54 KB, patch)
2012-01-17 17:05 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (11.51 KB, patch)
2012-01-17 18:54 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-01-17 17:05:44 PST
Created attachment 122840 [details] Patch
Hajime Morrita
Comment 2 2012-01-17 18:29:30 PST
Comment on attachment 122840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122840&action=review > Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:37 > +static const int defaultTileHeigth = 256; It looks this should be just const int, without static. Static is for static variables, which are usually staying inside c/cpp file. > Source/WebKit/efl/ewk/ewk_tiled_backing_store.h:39 > +static const float zoomStepMinimum = 0.01; Ditto.
Gyuyoung Kim
Comment 3 2012-01-17 18:54:55 PST
Created attachment 122863 [details] Patch
WebKit Review Bot
Comment 4 2012-01-17 20:28:53 PST
Comment on attachment 122863 [details] Patch Clearing flags on attachment: 122863 Committed r105240: <http://trac.webkit.org/changeset/105240>
WebKit Review Bot
Comment 5 2012-01-17 20:28:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.