Bug 76495

Summary: Reduce the number of compositing test failures
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dino, jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Simon Fraser (smfr)
Reported 2012-01-17 16:40:51 PST
Compositing tests are in a sorry state. Fixing them up.
Attachments
Patch (855.45 KB, patch)
2012-01-17 17:10 PST, Simon Fraser (smfr) 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-01-17 17:10:29 PST
Created attachment 122842 [details] Patch
James Robinson
Comment 2 2012-01-17 17:13:13 PST
Comment on attachment 122842 [details] Patch RS=me
WebKit Review Bot
Comment 3 2012-01-17 17:14:14 PST
Attachment 122842 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/comp..." exit_code: 1 LayoutTests/ChangeLog:7: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] LayoutTests/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] LayoutTests/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] LayoutTests/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] WARNING: Exception running driver: [u'/mnt/git/webkit-style-queue/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations(). Total errors found: 4 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 4 2012-01-17 17:18:56 PST
http://trac.webkit.org/changeset/105219
Note You need to log in before you can comment on or make changes to this bug.