Bug 76495 - Reduce the number of compositing test failures
Summary: Reduce the number of compositing test failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-17 16:40 PST by Simon Fraser (smfr)
Modified: 2012-01-17 17:18 PST (History)
5 users (show)

See Also:


Attachments
Patch (855.45 KB, patch)
2012-01-17 17:10 PST, Simon Fraser (smfr)
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-01-17 16:40:51 PST
Compositing tests are in a sorry state. Fixing them up.
Comment 1 Simon Fraser (smfr) 2012-01-17 17:10:29 PST
Created attachment 122842 [details]
Patch
Comment 2 James Robinson 2012-01-17 17:13:13 PST
Comment on attachment 122842 [details]
Patch

RS=me
Comment 3 WebKit Review Bot 2012-01-17 17:14:14 PST
Attachment 122842 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/comp..." exit_code: 1

LayoutTests/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
LayoutTests/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
LayoutTests/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
WARNING: Exception running driver: [u'/mnt/git/webkit-style-queue/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory.  Driver must be built before calling WebKitPort.test_expectations().
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2012-01-17 17:18:56 PST
http://trac.webkit.org/changeset/105219