Bug 76484

Summary: Check style on test_expectations.txt files before commit
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, brian.holt, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ojan Vafai
Reported 2012-01-17 15:33:10 PST
Check style on test_expectations.txt files before commit
Attachments
Patch (6.00 KB, patch)
2012-01-17 15:49 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (5.71 KB, patch)
2012-01-18 14:21 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-01-17 15:49:36 PST
Created attachment 122829 [details] Patch
Adam Barth
Comment 2 2012-01-17 16:24:17 PST
Comment on attachment 122829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122829&action=review Nice approach. Thanks. > Tools/Scripts/webkitpy/tool/steps/commit.py:60 > + if not len(test_expectations_files): > + return You can just say: if not test_expectations_files: the empty list is falsy.
Ojan Vafai
Comment 3 2012-01-17 16:41:18 PST
Committed r105213: <http://trac.webkit.org/changeset/105213>
Ojan Vafai
Comment 4 2012-01-18 14:21:03 PST
Reopening to attach new patch.
Ojan Vafai
Comment 5 2012-01-18 14:21:06 PST
Created attachment 122993 [details] Patch
Ojan Vafai
Comment 6 2012-01-18 14:22:02 PST
Comment on attachment 122993 [details] Patch Whoops. Wrong bug...
Brian Holt
Comment 7 2013-07-17 01:43:35 PDT
(In reply to comment #6) > (From update of attachment 122993 [details]) > Whoops. Wrong bug... Was this bug was reopened incorrectly? Can we close it?
Zan Dobersek
Comment 8 2013-07-17 02:05:01 PDT
I think so.
Note You need to log in before you can comment on or make changes to this bug.