Bug 76481

Summary: webkitpy: fix json import in json_results_generator_unittest.py
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Dirk Pranke
Reported 2012-01-17 14:48:33 PST
webkitpy: fix json import on linux
Attachments
Patch (2.11 KB, patch)
2012-01-17 14:49 PST, Dirk Pranke 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-01-17 14:49:33 PST
Created attachment 122816 [details] Patch
Dirk Pranke
Comment 2 2012-01-17 15:08:35 PST
ick ... okay, the distribution of python on my linux box seems to point to some glacially old version of simplejson that does actually have a speedups.so compiled, so when we load the version in thirdparty/simplejson, it picks up an old speedups.so and explodes. Note that the import in simplejson/encoder.py is "from simplejson import _speedups"; since our module is known as "webkitpy.thirdparty.simplejson" this is how we end up getting the wrong version here. importing json directly is probably the right way to avoid this version skew.
Dirk Pranke
Comment 3 2012-01-17 15:10:56 PST
Committed r105199: <http://trac.webkit.org/changeset/105199>
Eric Seidel (no email)
Comment 4 2012-01-17 18:46:42 PST
We're about to remove support for 2.5 anyway. :)
Note You need to log in before you can comment on or make changes to this bug.