Bug 76477

Summary: add test expections ahead of skia DEPS roll
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: epoger, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mike Reed
Reported 2012-01-17 13:20:39 PST
add test expections ahead of skia DEPS roll
Attachments
Patch (3.22 KB, patch)
2012-01-17 13:23 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2012-01-18 06:52 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2012-01-17 13:23:33 PST
Created attachment 122804 [details] Patch
Stephen White
Comment 2 2012-01-17 14:16:58 PST
Comment on attachment 122804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122804&action=review r=me, but a comment would be nice. > LayoutTests/platform/chromium/test_expectations.txt:1111 > +//BUGCR105305 MAC : fast/borders/border-image-rotate-transform.html = IMAGE Probably should add a comment here explaining why it's commented out. Is it still expected to be wrong after the skia roll? Or just wrong in a new way? If neither, it should just be removed.
WebKit Review Bot
Comment 3 2012-01-18 05:01:33 PST
Comment on attachment 122804 [details] Patch Rejecting attachment 122804 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 NOBODY just expectations changes found in /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11282176
Mike Reed
Comment 4 2012-01-18 06:52:52 PST
Created attachment 122919 [details] Patch
Mike Reed
Comment 5 2012-01-18 06:56:44 PST
addressed comment in #2, added "Unreviewed" to ChangeLog
Stephen White
Comment 6 2012-01-18 09:38:50 PST
Comment on attachment 122919 [details] Patch Looks good. r=me
WebKit Review Bot
Comment 7 2012-01-18 11:59:56 PST
Comment on attachment 122919 [details] Patch Clearing flags on attachment: 122919 Committed r105304: <http://trac.webkit.org/changeset/105304>
WebKit Review Bot
Comment 8 2012-01-18 12:00:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.