Bug 76471

Summary:

Move RunLoop to WebCore/platform

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo.noronha, gustavo, levin+threading, webkit.review.bot, xan.lopez, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

78504

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	andersca: review+, gustavo.noronha: commit-queue-

Sam Weinig

Reported 2012-01-17 12:09:25 PST

Move RunLoop to WebCore/platform

Attachments
Patch (127.12 KB, patch) 2012-01-17 12:10 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (127.36 KB, patch) 2012-01-17 18:37 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (127.95 KB, patch) 2012-01-18 13:46 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (125.44 KB, patch) 2012-01-18 14:05 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (125.60 KB, patch) 2012-01-18 16:47 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (126.16 KB, patch) 2012-01-19 10:14 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (126.18 KB, patch) 2012-01-19 11:36 PST, Sam Weinig	andersca: review+ gustavo.noronha: commit-queue-	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2012-01-17 12:10:09 PST

Created attachment 122796 [details] Patch

WebKit Review Bot

Comment 2 2012-01-17 13:15:44 PST

Attachment 122796 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/WebProcess/win/WebProcessMainWin.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Platform/CoreIPC/Connection.h:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/platform/qt/RunLoopQt.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/RunLoopQt.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/RunLoopQt.cpp:38: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/PluginProcess/PluginProcess.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/Launcher/win/ThreadLauncherWin.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 11 in 62 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2012-01-17 13:27:15 PST

Comment on attachment 122796 [details] Patch Attachment 122796 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11111303

Gustavo Noronha (kov)

Comment 4 2012-01-17 13:44:16 PST

Comment on attachment 122796 [details] Patch Attachment 122796 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11268315

Sam Weinig

Comment 5 2012-01-17 18:37:12 PST

Created attachment 122859 [details] Patch

Gustavo Noronha (kov)

Comment 6 2012-01-17 22:50:08 PST

Comment on attachment 122859 [details] Patch Attachment 122859 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11283088