Bug 76439

Summary: <content> should create HTMLContentElement object
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dominicc, gustavo.noronha, gustavo, hayato, morrita, ojan, rakuco, rolandsteiner, shinyak, vestbo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76353    
Bug Blocks: 76434    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-01-17 01:44:08 PST
We should be able to parse <content select="..." ...>.
Attachments
WIP (4.78 KB, patch)
2012-01-18 22:43 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
WIP (6.85 KB, patch)
2012-01-20 04:26 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
WIP (18.72 KB, patch)
2012-01-24 13:55 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (23.60 KB, patch)
2012-01-24 17:12 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.00 KB, patch)
2012-01-25 09:52 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-01-18 20:56:06 PST
In this change I'll add - HTMLContentElement - content to HTMLNames.in behind the flag. The flag will be added in Bug 76353.
Hajime Morrita
Comment 2 2012-01-18 22:43:05 PST
Created attachment 123075 [details] WIP
Hajime Morrita
Comment 3 2012-01-20 04:26:11 PST
Created attachment 123288 [details] WIP
Hajime Morrita
Comment 4 2012-01-20 04:29:37 PST
(In reply to comment #3) > Created an attachment (id=123288) [details] > WIP It looks that the nested case doesn't work. I need to care about that.
Hajime Morrita
Comment 5 2012-01-24 13:55:35 PST
Created attachment 123801 [details] WIP
Hajime Morrita
Comment 6 2012-01-24 17:12:09 PST
Created attachment 123849 [details] Patch
Hajime Morrita
Comment 7 2012-01-24 17:13:02 PST
Hi Dimitri, could you take a look at this? <content> is coming here.
WebKit Review Bot
Comment 8 2012-01-24 19:08:19 PST
Comment on attachment 123849 [details] Patch Attachment 123849 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11344179 New failing tests: media/audio-garbage-collect.html
Collabora GTK+ EWS bot
Comment 9 2012-01-25 04:03:56 PST
Comment on attachment 123849 [details] Patch Attachment 123849 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11344493
Hajime Morrita
Comment 10 2012-01-25 09:52:12 PST
Created attachment 123963 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-01-25 12:47:52 PST
Comment on attachment 123963 [details] Patch for landing Clearing flags on attachment: 123963 Committed r105917: <http://trac.webkit.org/changeset/105917>
WebKit Review Bot
Comment 12 2012-01-25 12:47:59 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 13 2012-01-26 00:58:29 PST
Comment on attachment 123963 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=123963&action=review > LayoutTests/platform/qt/test_expectations.txt:10 > +// Needs ENABLE_SHADOW_DOM > +BUGWK76439 DEBUG : fast/dom/shadow/content-element-api.html = TEXT > +BUGWK76439 DEBUG : fast/dom/shadow/content-element-outside-shadow.html = TEXT > + These tests fail in release mode too. And we use Skipped list to disable tests because of not yet supported features. I landed the fix: http://trac.webkit.org/changeset/105973
Hajime Morrita
Comment 14 2012-01-26 09:01:45 PST
(In reply to comment #13) > > These tests fail in release mode too. And we use Skipped list > to disable tests because of not yet supported features. > > I landed the fix: http://trac.webkit.org/changeset/105973 Oooopsss. Thanks much for your catch. A series of my patches yesterday were totally broken...
Dimitri Glazkov (Google)
Comment 15 2012-01-26 09:03:22 PST
(In reply to comment #14) > (In reply to comment #13) > > > > These tests fail in release mode too. And we use Skipped list > > to disable tests because of not yet supported features. > > > > I landed the fix: http://trac.webkit.org/changeset/105973 > Oooopsss. Thanks much for your catch. > A series of my patches yesterday were totally broken... I blame the reviewer! :P Seriously, we must try to do better.
Note You need to log in before you can comment on or make changes to this bug.