| Summary: | Add <shadow> element. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Hayato Ito <hayato> |
| Component: | DOM | Assignee: | Hayato Ito <hayato> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, dglazkov, dominicc, gustavo, hayato, morrita, ojan, rakuco, rolandsteiner, shinyak, shinyak, vestbo, webkit.review.bot, xan.lopez |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 76433 | ||
| Attachments: | |||
|
Description
Hayato Ito
2012-01-17 01:07:43 PST
Created attachment 122733 [details]
WIP.
Comment on attachment 122733 [details] WIP. View in context: https://bugs.webkit.org/attachment.cgi?id=122733&action=review > Source/WebCore/html/HTMLTagNames.in:95 > +shadow interfaceName=HTMLShadowElement This needs to be conditional on SHADOW_DOM. > Source/WebCore/html/shadow/HTMLShadowElement.idl:33 > + interface HTMLShadowElement : HTMLElement { Needs to be conditional on SHADOW_DOM. > Needs to be conditional on SHADOW_DOM. The flag is going to introduced by Bug 76353, which is blocked by Bug 76358. Help wanted ;-) I think whole HTMLShadowElement.h/cpp also should be guarded by the conditional. (In reply to comment #3) > > Needs to be conditional on SHADOW_DOM. > The flag is going to introduced by Bug 76353, which is blocked by Bug 76358. > Help wanted ;-) > > I think whole HTMLShadowElement.h/cpp also should be guarded by the conditional. That last part probably won't work, since we need to keep details/summary working with the flag turned off. Created attachment 125086 [details]
try for build-bots.
Comment on attachment 125086 [details] try for build-bots. Attachment 125086 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11388759 Comment on attachment 125086 [details] try for build-bots. Attachment 125086 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11389786 Created attachment 125097 [details]
let me watch results of ews.
Comment on attachment 125097 [details] let me watch results of ews. Attachment 125097 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11396764 Comment on attachment 125097 [details] let me watch results of ews. Attachment 125097 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11387818 Created attachment 125104 [details]
let me watch results of ews again.
Comment on attachment 125104 [details] let me watch results of ews again. Attachment 125104 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11389825 Comment on attachment 125104 [details] let me watch results of ews again. Attachment 125104 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11381815 Created attachment 125116 [details]
let me watch results of ews again, updating HTMLElementsAllInOne.cpp
Comment on attachment 125116 [details] let me watch results of ews again, updating HTMLElementsAllInOne.cpp Attachment 125116 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11393763 Comment on attachment 125116 [details] let me watch results of ews again, updating HTMLElementsAllInOne.cpp Attachment 125116 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11394799 Created attachment 125126 [details]
let me watch results of ews again, JSHTMLShadowElement is guared
Comment on attachment 125126 [details] let me watch results of ews again, JSHTMLShadowElement is guared Attachment 125126 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11393774 Comment on attachment 125126 [details] let me watch results of ews again, JSHTMLShadowElement is guared Attachment 125126 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11386824 Comment on attachment 125126 [details] let me watch results of ews again, JSHTMLShadowElement is guared Attachment 125126 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11394914 Created attachment 125238 [details]
let me watch results of ews again, idl is now guarded
Comment on attachment 125238 [details] let me watch results of ews again, idl is now guarded Attachment 125238 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11422052 Created attachment 125243 [details]
let me watch results of ews again, fix idl
Created attachment 125293 [details]
Fix mac build hopefully
Created attachment 125309 [details]
ready for review (hopefully).
Comment on attachment 125309 [details] ready for review (hopefully). View in context: https://bugs.webkit.org/attachment.cgi?id=125309&action=review > LayoutTests/fast/dom/shadow/shadow-element.html:13 > +// We don't have to guard this by SHADOW_DOM flag for now. Right -- so how is this test useful? :) Not useful for now. :) That only ensures that crash does not happen when HTMLShadowElement is created with SHADOW_DOM flag. I'll land this patch to move forward. Thank you. (In reply to comment #26) > (From update of attachment 125309 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125309&action=review > > > LayoutTests/fast/dom/shadow/shadow-element.html:13 > > +// We don't have to guard this by SHADOW_DOM flag for now. > > Right -- so how is this test useful? :) Comment on attachment 125309 [details] ready for review (hopefully). Rejecting attachment 125309 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 2 /HTMLShadowElement.h:48: error: 'MappedAttributeEntry' has not been declared CXX(target) out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources12.o CXX(target) out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources13.o CXX(target) out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources14.o make: *** [out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources08.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/11434078 Created attachment 125565 [details]
fix builds.
I've upload a new patch to fix build. I am still wondering why EWS-bots could not catch this type of build error which commit-queue could catch. Since mac-ews has not been working either with or without this patch, let me land this patch and watch the tree. (In reply to comment #30) > I've upload a new patch to fix build. > I am still wondering why EWS-bots could not catch this type of build error which commit-queue could catch. Created attachment 125596 [details]
Patch for landing
Created attachment 125597 [details]
Patch for landing
Comment on attachment 125597 [details] Patch for landing Clearing flags on attachment: 125597 Committed r106794: <http://trac.webkit.org/changeset/106794> All reviewed patches have been landed. Closing bug. |