Bug 76382

Summary: Web Inspector: CodeGeneratorInspector.py: start using typedefs
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, prybin, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72861    
Attachments:
Description Flags
Patch
none
InspectorFrontend.h base version
none
New InspectorFrontend.h
none
Generator output diff
none
Patch none

Description Peter Rybin 2012-01-16 07:16:01 PST 
Currently we generated typedefs for named string types, but not use them. Start using them.
Comment 1 Peter Rybin 2012-01-16 07:22:03 PST 
Created attachment 122632 [details]
Patch
Comment 2 Peter Rybin 2012-01-16 07:32:13 PST 
Created attachment 122633 [details]
InspectorFrontend.h base version
Comment 3 Peter Rybin 2012-01-16 07:33:02 PST 
Created attachment 122634 [details]
New InspectorFrontend.h
Comment 4 Peter Rybin 2012-01-16 07:33:55 PST 
Created attachment 122635 [details]
Generator output diff
Comment 5 Yury Semikhatsky 2012-01-16 07:47:07 PST 
Comment on attachment 122632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122632&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:661
>                              return

return None?
Comment 6 Peter Rybin 2012-01-16 12:03:18 PST 
Created attachment 122670 [details]
Patch
Comment 7 WebKit Review Bot 2012-01-17 07:46:02 PST 
Comment on attachment 122670 [details]
Patch

Clearing flags on attachment: 122670

Committed r105160: <http://trac.webkit.org/changeset/105160>
Comment 8 WebKit Review Bot 2012-01-17 07:46:08 PST 
All reviewed patches have been landed.  Closing bug.