Bug 76364

Summary: Add tests for dynamic attribute changes and svg for mapping of lang/xml:lang to -webkit-locale
Product: WebKit Reporter: Matt Falkenhagen <falken>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: ASSIGNED    
Severity: Normal CC: ap, jshin, morrita, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 53783, 80658    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Matt Falkenhagen
Reported 2012-01-15 21:58:34 PST
Spin off of Alexey's comment on bug 67586: https://bugs.webkit.org/show_bug.cgi?id=67586#c34
Attachments
Patch (3.70 KB, patch)
2012-01-18 18:20 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2012-02-06 22:06 PST, Matt Falkenhagen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Falkenhagen
Comment 1 2012-01-18 18:20:31 PST
Created attachment 123049 [details] Patch
Matt Falkenhagen
Comment 2 2012-02-06 22:06:19 PST
Created attachment 125768 [details] Patch
Hajime Morrita
Comment 3 2012-02-20 21:04:21 PST
Comment on attachment 125768 [details] Patch Basically looks good. Maybe we could have test with removeAttribute().
Matt Falkenhagen
Comment 4 2012-03-08 17:37:35 PST
Comment on attachment 125768 [details] Patch Thanks for the review. I've put a revised patch at bug 80658 since it doesn't deal with SVG at all.
Hajime Morrita
Comment 5 2012-03-08 17:59:41 PST
(In reply to comment #4) > (From update of attachment 125768 [details]) > Thanks for the review. I've put a revised patch at bug 80658 since it doesn't deal with SVG at all. So is it OK to close this?
Matt Falkenhagen
Comment 6 2012-03-08 18:39:07 PST
I was planning to keep this bug open as it includes adding tests for SVG, which hasn't been worked on yet, and treat bug 80658 as a subtask of it.
Simon Fraser (smfr)
Comment 7 2013-03-18 18:02:08 PDT
fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml is often flakey: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r146151%20(6480)/fast/css/lang-mapped-to-webkit-locale-dynamic-pretty-diff.html
Matt Falkenhagen
Comment 8 2017-07-18 17:16:23 PDT
I believe the remaining task here is adding tests for mapping of lang/xml:lang to -webkit-locale when lang/xml:lang was set in SVG.
Note You need to log in before you can comment on or make changes to this bug.