Bug 76344

Summary: [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKit2Assignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76343    
Attachments:
Description Flags
Patch
none
Patch adding test none

Martin Robinson
Reported 2012-01-15 09:16:36 PST
During policy decision, navigation events that were not triggered by the mouse should claim that they were triggered by WebMouseEvent::NoButton intsead of WebMouseEvent::LeftButton.
Attachments
Patch (2.47 KB, patch)
2012-01-15 10:33 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch adding test (4.60 KB, patch)
2012-01-21 12:06 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-01-15 10:33:58 PST
Created attachment 122569 [details] Patch
Sam Weinig
Comment 2 2012-01-20 16:21:42 PST
Comment on attachment 122569 [details] Patch If you can, it would be great to add a test case to TestWebKitAPI, but it is not absolutely necessary for this simple a fix.
Martin Robinson
Comment 3 2012-01-21 12:06:17 PST
Created attachment 123454 [details] Patch adding test
Martin Robinson
Comment 4 2012-01-21 12:09:22 PST
Added a patch with a test. GTK+ doesn't yet build the C API tests yet, so I'm doing this blindly. If it passes the EWS I'll land it and watch the bots. Thanks for the review!
Martin Robinson
Comment 5 2012-01-25 12:37:19 PST
Committed r105916: <http://trac.webkit.org/changeset/105916>
Note You need to log in before you can comment on or make changes to this bug.