Bug 76326

Summary:

getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

CSS

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62048

Attachments:

Description	Flags
Patch	tony: review+

Description Ojan Vafai 2012-01-13 18:48:00 PST

Summary: getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value

Comment 1 Ojan Vafai 2012-02-15 11:54:19 PST

Created attachment 127209 [details]
Patch

Comment 2 Tony Chang 2012-02-15 12:05:29 PST

Comment on attachment 127209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127209&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1587
> +            if (m_node && m_node->parentNode() && m_node->parentNode()->computedStyle() && style->flexItemAlign() == AlignAuto)

I would put the style->flexItemAlign() == AlignAuto check first so we don't do all the other checks for other alignments.

Comment 3 Ojan Vafai 2012-02-15 12:26:59 PST

Committed r107833: <http://trac.webkit.org/changeset/107833>