Bug 76305
| Summary: | Templatizing CSSValuePool::createIdentifierValue() would simplify CSSComputedStyleDeclaration::getPropertyCSSValue() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Lee <jonlee> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Jon Lee
In the case of CSSPropertyTextOverflow we see this code:
case CSSPropertyTextOverflow:
if (style->textOverflow())
return cssValuePool->createIdentifierValue(CSSValueEllipsis);
return cssValuePool->createIdentifierValue(CSSValueClip);
Templatizing createIdentifierValue() would allow us to reduce this to just one line, leverage the mappings implemented in CSSPrimitiveValueMappings.h.
(See https://bugs.webkit.org/show_bug.cgi?id=76118#c8)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/10692989>