Bug 76297

Summary: Partially revert r104756 - multipart bugs
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, koivisto, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch for landing none

Description Nate Chapin 2012-01-13 12:22:14 PST
The multipart code in SubresourceLoader has some subtleties I misunderstood when I tried to change them in http://trac.webkit.org/changeset/104756. That patch is causing a multipart test to assert in chromium win, and I suspect there are other issues I haven't found yet.

I'm going to revert all the multipart changes (except the changes to CachedImage and when we call clear()) and give them more thought before trying again.
Comment 1 Nate Chapin 2012-01-13 12:54:45 PST
Created attachment 122485 [details]
patch
Comment 2 Alexey Proskuryakov 2012-01-13 12:55:38 PST
Comment on attachment 122485 [details]
patch

rs=me
Comment 3 Early Warning System Bot 2012-01-13 13:04:40 PST
Comment on attachment 122485 [details]
patch

Attachment 122485 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11152701
Comment 4 Nate Chapin 2012-01-13 14:51:18 PST
Created attachment 122505 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-13 15:33:00 PST
Comment on attachment 122505 [details]
Patch for landing

Clearing flags on attachment: 122505

Committed r105000: <http://trac.webkit.org/changeset/105000>
Comment 6 WebKit Review Bot 2012-01-13 15:33:05 PST
All reviewed patches have been landed.  Closing bug.