Bug 76276

Summary: [Qt] [WK2] Get rid of the dependency to QtWidgets
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76275    
Bug Blocks: 78109    
Attachments:
Description Flags
proposed patch none

Andras Becsi
Reported 2012-01-13 07:54:27 PST
QScroller is going away from Qt5 (and QtWebKit) soon thus we should drop its widgets dependency as well.
Attachments
proposed patch (12.37 KB, patch)
2012-02-20 08:50 PST, Andras Becsi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2012-02-20 08:50:19 PST
Created attachment 127822 [details] proposed patch This patch probably needs a clean build for the bot.
Simon Hausmann
Comment 2 2012-02-20 12:54:07 PST
Comment on attachment 127822 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=127822&action=review LGTM, but I think the code in ActivateFontsQt.cpp should be re-added before landing. > Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:-48 > -#endif Don't we still need these for the layout tests for the time being? It's okay to use Widget stuff in WTR / the bundle, since this code isn't in the library itself.
Andras Becsi
Comment 3 2012-02-21 02:57:38 PST
Committed r108328: <http://trac.webkit.org/changeset/108328>
Andras Becsi
Comment 4 2012-02-21 02:58:23 PST
Comment on attachment 127822 [details] proposed patch Clearing flags from attachment.
Note You need to log in before you can comment on or make changes to this bug.