Bug 76264

Summary:

Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Raymond Toy <rtoy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

76277

Bug Blocks:

75386

Attachments:

Description	Flags
Patch	none

Vsevolod Vlasov

Reported 2012-01-13 03:44:05 PST

Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector. This patch contains - new InspectorIndexedDBAgent backend boilerplate - new IndexedDBModel front-end boilerplate - proposed implementation of getDatabaseNames for all frames.

Attachments
Patch (36.98 KB, patch) 2012-01-13 04:08 PST, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2012-01-13 04:08:36 PST

Created attachment 122407 [details] Patch

Vsevolod Vlasov

Comment 2 2012-01-13 04:08:55 PST

This implementation is ready to review. Known issues: - xcode project is not yet updated. - There are no tests, I am going to add tests separately, once I implement ResourcePanel - IndexedDBModel interaction.

Pavel Feldman

Comment 3 2012-01-13 05:25:00 PST

Comment on attachment 122407 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122407&action=review > Source/WebCore/inspector/Inspector.json:111 > + { "name": "securityOrigin", "type": "string", "description": "Frame document's security origin." }, Should we make this field optional? > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:2 > + * Copyright (C) 2011 Google Inc. All rights reserved. 2012 > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:110 > + RefPtr<InspectorObject> result = InspectorObject::create(); You should use new generated API for front-end messages. > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:166 > + m_enabled = true; I don't introduce these unless performance matters. > Source/WebCore/inspector/InspectorIndexedDBAgent.h:2 > + * Copyright (C) 2011 Google Inc. All rights reserved. 2012 > Source/WebCore/inspector/front-end/IndexedDBModel.js:2 > + * Copyright (C) 2011 Google Inc. All rights reserved. 2012 > Source/WebCore/inspector/front-end/IndexedDBModel.js:203 > + Extra blank line.

Vsevolod Vlasov

Comment 4 2012-01-13 07:08:48 PST

Committed r104935: <http://trac.webkit.org/changeset/104935>

Vsevolod Vlasov

Comment 5 2012-01-13 08:28:30 PST

Committed r104940: <http://trac.webkit.org/changeset/104940>

Note You need to log in before you can comment on or make changes to this bug.