Summary: | Select attribute of HTMLContentElement should be able to be changed dynamically. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 56973, 75301, 77584 | ||||||||
Attachments: |
|
Description
Shinya Kawanaka
2012-01-13 02:20:58 PST
Created attachment 124898 [details]
Patch
Comment on attachment 124898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124898&action=review > Source/WebCore/html/shadow/HTMLContentElement.cpp:128 > + root->shadowHost()->setNeedsStyleRecalc(); Do we need both? I hope setNeedsShadowTreeStyleRecalc() sufficient. > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:122 > + document.getElementById('expect-container').innerHTML = "<div><span>BEFORE</span><span>LIGHT 2</span><span>AFTER</span></div>"; How about to reverse the order between above two lines to minimize side-effect of innerHTML setter? > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:244 > + If we already have similar test, could you consider to share the test framework? Comment on attachment 124898 [details] Patch Attachment 124898 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11389387 Created attachment 125048 [details]
Patch
(In reply to comment #2) > (From update of attachment 124898 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124898&action=review > > > Source/WebCore/html/shadow/HTMLContentElement.cpp:128 > > + root->shadowHost()->setNeedsStyleRecalc(); > > Do we need both? I hope setNeedsShadowTreeStyleRecalc() sufficient. Done. > > > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:122 > > + document.getElementById('expect-container').innerHTML = "<div><span>BEFORE</span><span>LIGHT 2</span><span>AFTER</span></div>"; > > How about to reverse the order between above two lines to minimize side-effect of innerHTML setter? Done. > > > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:244 > > + > > If we already have similar test, could you consider to share the test framework? I want to do this in a separate bug. Comment on attachment 125048 [details] Patch Clearing flags on attachment: 125048 Committed r106527: <http://trac.webkit.org/changeset/106527> All reviewed patches have been landed. Closing bug. |