Bug 76261 – Select attribute of HTMLContentElement should be able to be changed dynamically.

• Component: DOM
• Status: RESOLVED FIXED

[Shinya Kawanaka]

The select attribute introduced in Bug 75302 cannot be changed dynamically.
When select is changed, re-layout or something should occur.

[Shinya Kawanaka]

Created attachment 124898 [details]
Patch

[Hajime Morrita]

Comment on attachment 124898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124898&action=review

> Source/WebCore/html/shadow/HTMLContentElement.cpp:128
> +            root->shadowHost()->setNeedsStyleRecalc();

Do we need both? I hope setNeedsShadowTreeStyleRecalc() sufficient.

> LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:122
> +            document.getElementById('expect-container').innerHTML = "<div><span>BEFORE</span><span>LIGHT 2</span><span>AFTER</span></div>";

How about to reverse the order between above two lines to minimize side-effect of innerHTML setter?

> LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:244
> +

If we already have similar test, could you consider to share the test framework?

[Gyuyoung Kim]

Comment on attachment 124898 [details]
Patch

Attachment 124898 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11389387

[Shinya Kawanaka]

Created attachment 125048 [details]
Patch

[Shinya Kawanaka]

(In reply to comment #2)
> (From update of attachment 124898 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124898&action=review
> 
> > Source/WebCore/html/shadow/HTMLContentElement.cpp:128
> > +            root->shadowHost()->setNeedsStyleRecalc();
> 
> Do we need both? I hope setNeedsShadowTreeStyleRecalc() sufficient.

Done.

> 
> > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:122
> > +            document.getElementById('expect-container').innerHTML = "<div><span>BEFORE</span><span>LIGHT 2</span><span>AFTER</span></div>";
> 
> How about to reverse the order between above two lines to minimize side-effect of innerHTML setter?

Done.

> 
> > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:244
> > +
> 
> If we already have similar test, could you consider to share the test framework?

I want to do this in a separate bug.

[WebKit Review Bot]

Comment on attachment 125048 [details]
Patch

Clearing flags on attachment: 125048

Committed r106527: <http://trac.webkit.org/changeset/106527>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.