Bug 77584 - Refactoring: Share test drivers of shadow content tests.
Summary: Refactoring: Share test drivers of shadow content tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 76261 76262
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-01 17:12 PST by Shinya Kawanaka
Modified: 2012-02-02 19:33 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.02 KB, patch)
2012-02-02 00:12 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (14.06 KB, patch)
2012-02-02 16:55 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-02-01 17:12:36 PST
Currently we're using almost same test drivers in several shadow content tests.
Definitely we can share the code.
Comment 1 Shinya Kawanaka 2012-02-02 00:12:12 PST
Created attachment 125087 [details]
Patch
Comment 2 Hajime Morrita 2012-02-02 01:21:17 PST
Comment on attachment 125087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125087&action=review

> LayoutTests/ChangeLog:13
> +        * fast/dom/shadow/shadow-test-driver.js: Added.

Could you move this under dom/resources/ ? That marks the file is not a test.
Comment 3 Shinya Kawanaka 2012-02-02 16:55:53 PST
Created attachment 125211 [details]
Patch
Comment 4 Hajime Morrita 2012-02-02 17:52:25 PST
Comment on attachment 125211 [details]
Patch

Nice!
Comment 5 WebKit Review Bot 2012-02-02 19:33:26 PST
Comment on attachment 125211 [details]
Patch

Clearing flags on attachment: 125211

Committed r106619: <http://trac.webkit.org/changeset/106619>
Comment 6 WebKit Review Bot 2012-02-02 19:33:31 PST
All reviewed patches have been landed.  Closing bug.