Bug 76252

Summary: Web Inspector: Detailed heap snapshot. _calculateFlags is too slow on a large heap snapshot.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Ilya Tikhonovsky
Reported 2012-01-13 00:23:14 PST
_calculateFlags speed is about 10k edges per second. It requires 150sec for the snapshot with 1.5m edges. The root of problem is var node = list.shift(); It is not effective in term of memory and cpu. In our case it can be replaced with pop().
Attachments
Patch (2.67 KB, patch)
2012-01-13 00:37 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-01-13 00:37:16 PST
Created attachment 122389 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-01-13 03:36:53 PST
Comment on attachment 122389 [details] Patch Clearing flags on attachment: 122389 Committed r104916: <http://trac.webkit.org/changeset/104916>
Ilya Tikhonovsky
Comment 3 2012-01-13 03:37:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.