[Mac][DRT] Should support --no-timeout

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Hajime Morrita]

This is a part of the effort to run Dromaeo on DRT.

[Ryosuke Niwa]

(In reply to comment #0)
> This is a part of the effort to run Dromaeo on DRT.

Alternatively, we can set a really high timeout (e.g. 30minutes) as done in perftestrunner:http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

[Hajime Morrita]

Created attachment 122367 [details]
Patch

[Hajime Morrita]

> Alternatively, we can set a really high timeout (e.g. 30minutes) as done in perftestrunner:http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Yes. It will work in both way. We need some watchdog somehow and there is one in NRWT.
I just posted no-timeout version.

[Hajime Morrita]

> Yes. It will work in both way. We need some watchdog somehow and there is one in NRWT.
> I just posted no-timeout version.
This is also useful when you run DRT on the debugger.

[Hajime Morrita]

CC-ing folks who will know Mac DRT well...

[Darin Adler]

Comment on attachment 122367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122367&action=review

Looks OK.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1109
> +    ASSERT(timer);
> +    waitToDumpWatchdog = timer;

Should also ASSERT(!waitToDumpWatchdog)

[Hajime Morrita]

Hi Darin,
Thanks much for your quick response!

> > Tools/DumpRenderTree/mac/DumpRenderTree.mm:1109
> > +    ASSERT(timer);
> > +    waitToDumpWatchdog = timer;
> 
> Should also ASSERT(!waitToDumpWatchdog)
Will fix before landing.

[Hajime Morrita]

Created attachment 122372 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 122372 [details]
Patch for landing

Rejecting attachment 122372 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11115837

[Hajime Morrita]

Created attachment 122375 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 122375 [details]
Patch for landing

Clearing flags on attachment: 122375

Committed r104902: <http://trac.webkit.org/changeset/104902>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.