| Summary: | test-webkitpy: should support classes and individual test names as well as modules | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 76022 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2012-01-12 17:19:12 PST
Created attachment 122347 [details]
Patch
Comment on attachment 122347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review > Tools/Scripts/webkitpy/test/cat_unittest.py:-31 > - This blank line should stay according to PEP8 > Tools/Scripts/webkitpy/test/main.py:261 > + if os.path.exists(os.path.join(os.path.dirname(d), relpath)): I'm tempted to say we should go through filesystem here, but then again, that's probably not needed. (In reply to comment #2) > (From update of attachment 122347 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review > > > Tools/Scripts/webkitpy/test/cat_unittest.py:-31 > > - > > This blank line should stay according to PEP8 > Yeah, I'm not sure how that crept in. > > Tools/Scripts/webkitpy/test/main.py:261 > > + if os.path.exists(os.path.join(os.path.dirname(d), relpath)): > > I'm tempted to say we should go through filesystem here, but then again, that's probably not needed. I'm trying to avoid depending on anything (else) from webkitpy, but I suspect at some point I'll have to give just so I can write better tests. Committed r104977: <http://trac.webkit.org/changeset/104977> Committed r104980: <http://trac.webkit.org/changeset/104980> |