Summary: | Add mac-snowleopard pixel results for tests with scrollbars | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||
Component: | Tools / Tests | Assignee: | Emil A Eklund <eae> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Emil A Eklund
2012-01-12 16:29:33 PST
Created attachment 122348 [details]
Patch
Comment on attachment 122348 [details]
Patch
We could also consider fixing the tests so that they either didn't have scrollbars (overflow: hidden) or were dumpAsText() tests. But I'm definitely in favor of fewer tests failing.
Sure, I'll look at changing some of these to not use visible scrollbars. I'd prefer landing this as is for now though as it'll help us identify the tests we are failing on the subpixelbranch but passing on trunk. Thanks for the quick review. Go for it! I don't mean to get in the way of your greening of bots. I'm happy to review these sorts of patches all day! :) Great, thank you! Comment on attachment 122348 [details] Patch Clearing flags on attachment: 122348 Committed r104894: <http://trac.webkit.org/changeset/104894> All reviewed patches have been landed. Closing bug. |