Bug 76223

Summary: Add mac-snowleopard pixel results for tests with scrollbars
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Tools / TestsAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2012-01-12 16:29:33 PST
A bunch of our pixel tests fails on mac-snowleopard as the expected results are from lion where scrollbars are painted differently.
Attachments
Patch (640.17 KB, patch)
2012-01-12 17:30 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-01-12 17:30:41 PST
Created attachment 122348 [details] Patch
Eric Seidel (no email)
Comment 2 2012-01-12 18:58:07 PST
Comment on attachment 122348 [details] Patch We could also consider fixing the tests so that they either didn't have scrollbars (overflow: hidden) or were dumpAsText() tests. But I'm definitely in favor of fewer tests failing.
Emil A Eklund
Comment 3 2012-01-12 19:05:01 PST
Sure, I'll look at changing some of these to not use visible scrollbars. I'd prefer landing this as is for now though as it'll help us identify the tests we are failing on the subpixelbranch but passing on trunk. Thanks for the quick review.
Eric Seidel (no email)
Comment 4 2012-01-12 19:07:10 PST
Go for it! I don't mean to get in the way of your greening of bots. I'm happy to review these sorts of patches all day! :)
Emil A Eklund
Comment 5 2012-01-12 19:13:34 PST
Great, thank you!
WebKit Review Bot
Comment 6 2012-01-12 20:35:39 PST
Comment on attachment 122348 [details] Patch Clearing flags on attachment: 122348 Committed r104894: <http://trac.webkit.org/changeset/104894>
WebKit Review Bot
Comment 7 2012-01-12 20:35:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.