Bug 76203

Summary: [chromium] Fix DC leak in WebScreenInfoFactory.
Product: WebKit Reporter: David Levin <levin>
Component: WebKit Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76135    
Attachments:
Description Flags
Patch
none
Patch dimich: review+

Description David Levin 2012-01-12 12:46:13 PST 
See summary.
Comment 1 David Levin 2012-01-12 14:55:15 PST 
Created attachment 122315 [details]
Patch
Comment 2 Dmitry Titov 2012-01-12 15:05:55 PST 
Comment on attachment 122315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122315&action=review

Chromium will live! One note:

> Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:176
> +            ['include', 'win/OwnPtrWin\\.cpp$'],

Could we only have changes directly related to the DC fix? It would be easier to understand the patch.

> Source/JavaScriptCore/wtf/OwnPtrCommon.h:31
> +#if OS(WIN)

Same as above.
Comment 3 David Levin 2012-01-12 15:10:31 PST 
Created attachment 122317 [details]
Patch
Comment 4 David Levin 2012-01-12 15:34:55 PST 
Committed as http://trac.webkit.org/changeset/104867