Summary: | Add a check-webkit-style exception for GDBInterface.cpp | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sanjoy Das <thedigitalangel> | ||||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, levin, ojan, pnormand, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Sanjoy Das
2012-01-12 09:27:11 PST
Created attachment 122258 [details]
Add a check-webkit-style exception for GDBInterface.cpp
Comment on attachment 122258 [details] Add a check-webkit-style exception for GDBInterface.cpp Rejecting attachment 122258 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11209140 Created attachment 122539 [details]
Proposed patch
Comment on attachment 122539 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=122539&action=review It is looking good! The last missing bit is a little unittest in Tools/Scripts/webkitpy/style/checker_unittest.py maybe you can add it in test_path_rules_specifier. To run the tests use test-webkitpy. > Tools/ChangeLog:7 > + Unreviewed The Reviewed by NOBODY (OOPS!). line should remain. It is transformed to "Reviewed by Foo" by the commiter or the commit-queue bot. Created attachment 122812 [details]
Add a check-webkit-style exception for GDBInterface.cpp
+ a test case for the style checker.
Attachment 122812 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/style/checker_unittest.py:263: trailing whitespace [pep8/W291] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 122832 [details]
Add a check-webkit-style exception for GDBInterface.cpp
Comment on attachment 122832 [details] Add a check-webkit-style exception for GDBInterface.cpp View in context: https://bugs.webkit.org/attachment.cgi?id=122832&action=review This looks just fine to me, though there are a couple relaly minor style nits. > Tools/ChangeLog:4 > + Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so > + that it does not fail the style check. Typically this is the bug title itself and the description oes below the "Reviewed by" line. > Tools/Scripts/webkitpy/style/checker.py:230 > + # and __jit_debug_descriptor when integrating with gdb Missing a period here. > Tools/Scripts/webkitpy/style/checker_unittest.py:264 > + # Test if the exception for GDBInterface.cpp is in place Here as well. Created attachment 122835 [details]
Add a check-webkit-style exception for GDBInterface.cpp
This patch should fix the style errors.
Comment on attachment 122835 [details] Add a check-webkit-style exception for GDBInterface.cpp Clearing flags on attachment: 122835 Committed r105232: <http://trac.webkit.org/changeset/105232> All reviewed patches have been landed. Closing bug. |