Bug 76174 – [Qt] Zoom in to the focused node only when vkb starts becoming visible

• Component: WebKit2
• Status: RESOLVED FIXED

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 122236 [details]
Patch

[Simon Hausmann]

Comment on attachment 122236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122236&action=review

> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:442
> +void QtWebPageEventHandler::inputPanelVisibleChanged()
> +{
> +    if (!m_interactionEngine || !qApp->inputPanel()->visible())
> +        return;
> +
> +    const EditorState& editor = m_webPageProxy->editorState();
> +    m_interactionEngine->focusEditableArea(QRectF(editor.cursorRect), QRectF(editor.editorRect));

You're unconditionally connecting to the inputPanel's signal. Shouldn't the focusEditableArea call only be done if we have the focus? Perhaps we should also only connect when we receive focus and disconnect when we loose it?

[Kenneth Rohde Christiansen]

You are rigth, I will fix that!

[Kenneth Rohde Christiansen]

Created attachment 122399 [details]
Patch

[Kenneth Rohde Christiansen]

Created attachment 122408 [details]
Patch

[Kenneth Rohde Christiansen]

Landed in 105275