Summary: | [Meta] DRT should be able to run Dromaeo | ||
---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> |
Component: | Tools / Tests | Assignee: | Hajime Morrita <morrita> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | eric, rniwa, skyul |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 77512, 80079, 80776, 76242, 76245, 77328, 77329, 77504, 78303 | ||
Bug Blocks: | 77037 |
Description
Hajime Morrita
2012-01-12 01:47:26 PST
I understand that the performance measurement on DRT isn't perfect because it behaves differently from the real browsers in, for example, painting and event handling. But even so, this would be nice to have, especially for automation and easy to use. What kind of DRT changes do we need to make? Can't we already run Dromaeo if we modified the script a little bit? (In reply to comment #2) > What kind of DRT changes do we need to make? Can't we already run Dromaeo if we modified the script a little bit? What I found is that we need A. a way to supress timeout watchdog (Chromium already has it IIRC) B. an alternative for query string to specify the type of test to run. The file URL doesn't support the query string and supporting it looks a bit tricky on Mac. We don't need B if we can run it via HTTP server. But it would suffer the stability. So passing something like argument would help. (In reply to comment #3) > A. a way to supress timeout watchdog (Chromium already has it IIRC) I see. This should probably a layoutTestController/internals feature? > B. an alternative for query string to specify the type of test to run. > The file URL doesn't support the query string and supporting it looks a bit tricky on Mac. Really? Query string doesn't work on file URLs? (In reply to comment #4) > (In reply to comment #3) > > A. a way to supress timeout watchdog (Chromium already has it IIRC) > > I see. This should probably a layoutTestController/internals feature? Chromium DRT supports "--no-timeout" commandline option. So I'll follow that way. > > > B. an alternative for query string to specify the type of test to run. > > The file URL doesn't support the query string and supporting it looks a bit tricky on Mac. > > Really? Query string doesn't work on file URLs? It is a valid URL. But DRT (Mac DRT at least) doesn't handle it as expected. Because the file path is represented in URL object (in mac, its NSURL) and handled by the platform stack of each platform, we cannot rely on its edge behavior assuming we cannot change them. Well, providing a direct alternative is just an idea. We can explore another path. For example, providing a way to extra scripts (like content scripts of chromium extension) might be more flexible. Update: Now I made a small fork of Dromaeo for DRT. https://github.com/omo/dromaeo See https://github.com/omo/dromaeo/wiki/Running-on-DRT to try. I'm investigating how we can integrate this to run-perf-test Doesn't DRT already run Dromaeo as part of run-perf-tests? (In reply to comment #7) > Doesn't DRT already run Dromaeo as part of run-perf-tests? Right. this is used for tracking Dromaeo related test bugs but looks better to be merged to Bug 77037. *** This bug has been marked as a duplicate of bug 77037 *** |