Bug 76155

Summary: Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: bashi, dbates, efidler, rakuco, rwlbuis, tonikitoo, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kenichi Ishibashi
Reported 2012-01-12 01:19:54 PST
SimpleFontDataSkia.cpp doesn't contain Harfbuzz specific code so it should be located in Source/WebCore/platform/graphics/skia.
Attachments
Patch (21.53 KB, patch)
2012-01-12 01:23 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Patch (22.44 KB, patch)
2012-01-12 15:43 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-01-12 01:23:29 PST
Created attachment 122187 [details] Patch
Tony Chang
Comment 2 2012-01-12 10:11:45 PST
Comment on attachment 122187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:1710 > - ['include', 'platform/graphics/harfbuzz/SimpleFontDataSkia\\.cpp$'], > + ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'], I think you also need to exclude the file on mac and win. The mac code is around line 1661 and the win code is around line 1692.
Kenichi Ishibashi
Comment 3 2012-01-12 15:43:37 PST
Created attachment 122324 [details] Patch
Kenichi Ishibashi
Comment 4 2012-01-12 15:44:20 PST
Comment on attachment 122187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review Thank you for review! >> Source/WebCore/WebCore.gyp/WebCore.gyp:1710 >> + ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'], > > I think you also need to exclude the file on mac and win. The mac code is around line 1661 and the win code is around line 1692. Done.
Tony Chang
Comment 5 2012-01-12 16:02:09 PST
Comment on attachment 122324 [details] Patch Please watch the chromium bots when you land. Thanks!
Kenichi Ishibashi
Comment 6 2012-01-12 16:10:53 PST
(In reply to comment #5) > (From update of attachment 122324 [details]) > Please watch the chromium bots when you land. Thanks! I see. Thanks!
WebKit Review Bot
Comment 7 2012-01-12 16:28:06 PST
Comment on attachment 122324 [details] Patch Clearing flags on attachment: 122324 Committed r104876: <http://trac.webkit.org/changeset/104876>
WebKit Review Bot
Comment 8 2012-01-12 16:28:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.