Summary: | Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenichi Ishibashi <bashi> | ||||||
Component: | Platform | Assignee: | Kenichi Ishibashi <bashi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bashi, dbates, efidler, rakuco, rwlbuis, tonikitoo, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kenichi Ishibashi
2012-01-12 01:19:54 PST
Created attachment 122187 [details]
Patch
Comment on attachment 122187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:1710 > - ['include', 'platform/graphics/harfbuzz/SimpleFontDataSkia\\.cpp$'], > + ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'], I think you also need to exclude the file on mac and win. The mac code is around line 1661 and the win code is around line 1692. Created attachment 122324 [details]
Patch
Comment on attachment 122187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review Thank you for review! >> Source/WebCore/WebCore.gyp/WebCore.gyp:1710 >> + ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'], > > I think you also need to exclude the file on mac and win. The mac code is around line 1661 and the win code is around line 1692. Done. Comment on attachment 122324 [details]
Patch
Please watch the chromium bots when you land. Thanks!
(In reply to comment #5) > (From update of attachment 122324 [details]) > Please watch the chromium bots when you land. Thanks! I see. Thanks! Comment on attachment 122324 [details] Patch Clearing flags on attachment: 122324 Committed r104876: <http://trac.webkit.org/changeset/104876> All reviewed patches have been landed. Closing bug. |