Bug 76149

Summary: [chromium] Turn off FrameRateController timesource when it is not needed
Product: WebKit Reporter: Nat Duca <nduca>
Component: New BugsAssignee: Nat Duca <nduca>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, dglazkov, jamesr, klobag, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Without the fail
none
Patch for landing none

Nat Duca
Reported 2012-01-11 23:20:38 PST
[chromium] Turn off FrameRateController timesource when it is not needed
Attachments
Patch (20.28 KB, patch)
2012-01-11 23:21 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Without the fail (20.29 KB, patch)
2012-01-12 02:00 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.76 KB, patch)
2012-01-12 11:07 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2012-01-11 23:21:10 PST
Created attachment 122174 [details] Patch
WebKit Review Bot
Comment 2 2012-01-11 23:41:59 PST
Comment on attachment 122174 [details] Patch Attachment 122174 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11170705
Nat Duca
Comment 3 2012-01-12 02:00:40 PST
Created attachment 122191 [details] Without the fail
James Robinson
Comment 4 2012-01-12 10:11:28 PST
Comment on attachment 122191 [details] Without the fail View in context: https://bugs.webkit.org/attachment.cgi?id=122191&action=review R=me except the CCLayerTreeHostTest change, which I'm hoping is inadvertent. > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:227 > + // m_timedOut = true; > + // endTest(); what happened here?
Nat Duca
Comment 5 2012-01-12 10:54:19 PST
(In reply to comment #4) > > > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:227 > > + // m_timedOut = true; > > + // endTest(); > > what happened here? Oops. Overtired. Although, I should really try sneaking in "disable the entire test harness" edits like this more often, keep people on their toes. ;)
Nat Duca
Comment 6 2012-01-12 11:07:42 PST
Created attachment 122274 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-01-12 12:15:03 PST
Comment on attachment 122274 [details] Patch for landing Clearing flags on attachment: 122274 Committed r104844: <http://trac.webkit.org/changeset/104844>
WebKit Review Bot
Comment 8 2012-01-12 12:15:08 PST
All reviewed patches have been landed. Closing bug.
Nat Duca
Comment 9 2012-02-01 07:15:09 PST
*** Bug 75560 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.