Summary: | [chromium] Turn off FrameRateController timesource when it is not needed | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nat Duca <nduca> | ||||||||
Component: | New Bugs | Assignee: | Nat Duca <nduca> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cc-bugs, dglazkov, jamesr, klobag, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Nat Duca
2012-01-11 23:20:38 PST
Created attachment 122174 [details]
Patch
Comment on attachment 122174 [details] Patch Attachment 122174 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11170705 Created attachment 122191 [details]
Without the fail
Comment on attachment 122191 [details] Without the fail View in context: https://bugs.webkit.org/attachment.cgi?id=122191&action=review R=me except the CCLayerTreeHostTest change, which I'm hoping is inadvertent. > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:227 > + // m_timedOut = true; > + // endTest(); what happened here? (In reply to comment #4) > > > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:227 > > + // m_timedOut = true; > > + // endTest(); > > what happened here? Oops. Overtired. Although, I should really try sneaking in "disable the entire test harness" edits like this more often, keep people on their toes. ;) Created attachment 122274 [details]
Patch for landing
Comment on attachment 122274 [details] Patch for landing Clearing flags on attachment: 122274 Committed r104844: <http://trac.webkit.org/changeset/104844> All reviewed patches have been landed. Closing bug. |