Bug 76139

Summary:

[EFL][WK2] Add missing files to build webkit2/Efl.

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit2

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mariusz.g, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

61838

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Ryuan Choi

Reported 2012-01-11 18:53:37 PST

Patch will be added.

Attachments
Patch (8.42 KB, patch) 2012-01-11 19:09 PST, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (6.59 KB, patch) 2012-04-02 16:40 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (4.90 KB, patch) 2012-04-02 17:57 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (4.19 KB, patch) 2012-04-16 22:04 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryuan Choi

Comment 1 2012-01-11 19:09:55 PST

Created attachment 122155 [details] Patch

Gyuyoung Kim

Comment 2 2012-01-11 19:20:43 PST

Comment on attachment 122155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122155&action=review > Source/WebKit2/UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp:35 > + Missing #endif for ENABLE(PLUGIN_PROCESS)

Gyuyoung Kim

Comment 3 2012-01-11 23:51:37 PST

Comment on attachment 122155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122155&action=review >> Source/WebKit2/UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp:35 >> + > > Missing #endif for ENABLE(PLUGIN_PROCESS) Hmm, below line wasn't displayed on my browser certainly. Now, there is no problems. LGTM.

Ryuan Choi

Comment 4 2012-04-02 16:40:40 PDT

Created attachment 135226 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-04-02 17:31:28 PDT

Comment on attachment 135226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135226&action=review Are there plans to build WK2 by default from now on? > Source/WebKit2/UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp:23 > +#if ENABLE(PLUGIN_PROCESS) Don't you need to add this option to OptionsEfl.cmake?

Ryuan Choi

Comment 6 2012-04-02 17:48:40 PDT

(In reply to comment #5) > (From update of attachment 135226 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135226&action=review > > Are there plans to build WK2 by default from now on? Not now, but we are planning to enable webkit2 as default. > > > Source/WebKit2/UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp:23 > > +#if ENABLE(PLUGIN_PROCESS) > > Don't you need to add this option to OptionsEfl.cmake? Yes, it should be an option. After thinking while, PluginProcessProxyEfl is not needed until it is ready to upstream because I want to finish minimum webkit2/efl first. thanks.

Ryuan Choi

Comment 7 2012-04-02 17:57:58 PDT

Created attachment 135247 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 8 2012-04-02 18:03:03 PDT

Comment on attachment 135247 [details] Patch The patch looks OK to me.

Gyuyoung Kim

Comment 9 2012-04-02 18:56:33 PDT

Comment on attachment 135247 [details] Patch LGTM too.

Ryosuke Niwa

Comment 10 2012-04-16 21:49:51 PDT

Comment on attachment 135247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135247&action=review > Source/WebKit2/PlatformEfl.cmake:41 > - UIProcess/Plugins/efl/PluginInfoStoreEfl.cpp > - UIProcess/Plugins/efl/PluginProcessProxyEfl.cpp > + UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp What is this change?

Ryuan Choi

Comment 11 2012-04-16 22:04:19 PDT

Created attachment 137477 [details] Patch

Ryuan Choi

Comment 12 2012-04-16 22:08:06 PDT

Comment on attachment 137477 [details] Patch Thank you very much.

WebKit Review Bot

Comment 13 2012-04-16 22:47:12 PDT

Comment on attachment 137477 [details] Patch Clearing flags on attachment: 137477 Committed r114345: <http://trac.webkit.org/changeset/114345>

WebKit Review Bot

Comment 14 2012-04-16 22:47:18 PDT

All reviewed patches have been landed. Closing bug.

Mariusz Grzegorczyk

Comment 15 2012-04-17 08:26:48 PDT

There is missing Source/WebKit2/PlatformEfl.cmake change in latest patch.

Note You need to log in before you can comment on or make changes to this bug.