Bug 76099

Summary: test-webkitpy: fix -v and eliminate some spurious warnings
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Description Dirk Pranke 2012-01-11 13:26:57 PST 
test-webkitpy: fix -v and eliminate some spurious warnings
Comment 1 Dirk Pranke 2012-01-11 13:30:27 PST 
Created attachment 122083 [details]
Patch
Comment 2 Dirk Pranke 2012-01-11 13:32:48 PST 
Comment on attachment 122083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122083&action=review

> Tools/Scripts/webkitpy/test/main.py:119
> +            test_runner = unittest.TextTestRunner

Yes, unittest.main() is actually this stupid and needs a class passed in for -v to work.
Comment 3 Dirk Pranke 2012-01-11 13:42:32 PST 
Committed r104740: <http://trac.webkit.org/changeset/104740>
Comment 4 Eric Seidel (no email) 2012-01-11 13:58:09 PST 
Comment on attachment 122083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122083&action=review

OK.

> Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:47
> +            self._handle_style_error(self.line_number_from_json_exception(e), 'json/syntax', 5, str(e))

unicode?

> Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:51
> +        match = re.search(r': line (?P<line>\d+) column \d+', str(error))

unicode?