Summary: | The common case of content type = text/plain is not optimized and the plugin database is initialized instead | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Treat <manyoso> | ||||||||
Component: | Page Loading | Assignee: | Adam Treat <manyoso> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | hausmann, mitz, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Adam Treat
2012-01-11 12:05:41 PST
Created attachment 122067 [details]
Fix
I will further add that the DOMImplementation::createDocument still has misleading comments. Currently, image types != pdf and video are *also* not allowed to be overridden by plugins, but they plugin database is still initialized before these content types are evaluated. Should I fix this too or should I make it so plugins can override these too? Created attachment 122077 [details]
Revision based on feedback from andersca
I've revised the patch to take into account that image types != PDF and HTML5 video are also not optimized to be handled before initializing plugins. This is based on the assumption that these types should not be overridden by plugins which I think is correct and is currently the case.
Comment on attachment 122077 [details] Revision based on feedback from andersca Rejecting attachment 122077 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: u'Anders Carlsson', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/DOMImplementation.cpp Hunk #1 FAILED at 311. Hunk #2 succeeded at 322 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/dom/DOMImplementation.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Anders Carlsson', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/11108552 Created attachment 122088 [details]
Same patch on latest HEAD so it will apply
Just rebased on top of latest HEAD so commitbot can apply it.
Comment on attachment 122088 [details] Same patch on latest HEAD so it will apply Clearing flags on attachment: 122088 Committed r104746: <http://trac.webkit.org/changeset/104746> All reviewed patches have been landed. Closing bug. Comment on attachment 122088 [details] Same patch on latest HEAD so it will apply View in context: https://bugs.webkit.org/attachment.cgi?id=122088&action=review > Source/WebCore/dom/DOMImplementation.cpp:336 > + if (Image::supportsType(type) && type != "application/pdf" && type != "text/pdf") Most other PDF code in WebKit only supports application/pdf. It would be nice to clean this up one day. (In reply to comment #6) > (From update of attachment 122088 [details]) > Clearing flags on attachment: 122088 > > Committed r104746: <http://trac.webkit.org/changeset/104746> This change made iframes load PDFs as media documents, at least in OS X (where the media player supports PDFs), breaking PDF printing among other things. Filed bug 77079. |