Bug 76080

Summary: Webpages flash white when switching between windows
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2012-01-11 11:26:40 PST 
Webpages flash white when switching between windows
Comment 1 Anders Carlsson 2012-01-11 11:27:43 PST 
Created attachment 122057 [details]
Patch
Comment 2 mitz 2012-01-11 11:34:20 PST 
Comment on attachment 122057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122057&action=review

> Source/WebKit2/ChangeLog:9
> +        Introduce a _windowHasValidBackingStore boolean and only paint white if it's false.

Is it really unconditionally white?

> Source/WebKit2/ChangeLog:17
> +        * UIProcess/API/mac/WKView.mm:
> +        (-[WKView setFrameSize:]):
> +        (-[WKView viewDidMoveToWindow]):
> +        (-[WKView _windowDidMiniaturize:]):
> +        (-[WKView _windowDidChangeBackingProperties:]):
> +        (-[WKView drawRect:]):
> +

Please add comments here.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:192
> +    // The window server invalidates the backing store of whenever the window is resized or minimized.

Typo: “of whenever”.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1980
> +            // didn't paint with white, to avoid garbage in those areas.

Is it really always white?
Comment 3 Anders Carlsson 2012-01-11 11:38:35 PST 
Committed r104727: <http://trac.webkit.org/changeset/104727>