Bug 76071

Summary: Speech input: Send text to correct element even if focus has changed
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: leandrogracia, satish, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hans Wennborg
Reported 2012-01-11 09:46:35 PST
Speech input: Send text to correct element even if focus has changed
Attachments
Patch (5.77 KB, patch)
2012-01-11 09:49 PST, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (5.77 KB, patch)
2012-01-12 02:53 PST, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (5.76 KB, patch)
2012-01-12 03:16 PST, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2012-01-11 09:49:58 PST
Created attachment 122042 [details] Patch
Hans Wennborg
Comment 2 2012-01-12 02:53:21 PST
Created attachment 122198 [details] Patch Update patch, calling selectionChanged() whether or not the focus has changed to simplify the code flow.
Satish Sampath
Comment 3 2012-01-12 02:56:02 PST
Comment on attachment 122198 [details] Patch Source/WebCore/html/shadow/TextControlInnerElements.cpp > // selection has moved away from it. should this be 'focus has moved away' ? Looks good to me otherwise
Hans Wennborg
Comment 4 2012-01-12 03:16:42 PST
Created attachment 122201 [details] Patch Thanks Satish, uploading new patch that fixes the comment.
Steve Block
Comment 5 2012-01-12 05:22:18 PST
Comment on attachment 122201 [details] Patch r=me
WebKit Review Bot
Comment 6 2012-01-12 06:39:53 PST
Comment on attachment 122201 [details] Patch Clearing flags on attachment: 122201 Committed r104821: <http://trac.webkit.org/changeset/104821>
WebKit Review Bot
Comment 7 2012-01-12 06:39:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.