Bug 76066

Summary: Webaudio layout tests need to override the WebKitWebAudioEnabled
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Raymond Toy <rtoy>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, pnormand, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Raymond Toy
Reported 2012-01-11 09:12:09 PST
As noted in https://bugs.webkit.org/show_bug.cgi?id=75126#c41, we need to override the WebKitWebAudioEnabled LayoutTestController preference. It has to be set to 1. Some existing tests have this, but most do not.
Attachments
Patch (7.55 KB, patch)
2012-01-11 11:43 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2012-01-11 12:25 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raymond Toy
Comment 1 2012-01-11 11:43:30 PST
Created attachment 122059 [details] Patch
Chris Rogers
Comment 2 2012-01-11 11:52:21 PST
I don't remember much about this - I just added Tony for review here...
Philippe Normand
Comment 3 2012-01-11 12:05:34 PST
Comment on attachment 122059 [details] Patch I initially added this in LayoutTests/webaudio/resources/audio-testing.js so at least all tests importing that js script are ok, fwiw :)
Tony Chang
Comment 4 2012-01-11 12:05:59 PST
Comment on attachment 122059 [details] Patch It looks like this is done by LayoutTests/webaudio/resources/audio-testing.js which is include by most of the files. Looks like only convolution-mono-mono.html needs it added (or needs to include audio-testing.js).
Raymond Toy
Comment 5 2012-01-11 12:25:53 PST
Created attachment 122072 [details] Patch
Raymond Toy
Comment 6 2012-01-11 12:27:00 PST
(In reply to comment #4) > (From update of attachment 122059 [details]) > It looks like this is done by LayoutTests/webaudio/resources/audio-testing.js which is include by most of the files. Looks like only convolution-mono-mono.html needs it added (or needs to include audio-testing.js). Thanks. That's a much better solution. Updated patch accordingly.
WebKit Review Bot
Comment 7 2012-01-11 13:12:35 PST
Comment on attachment 122072 [details] Patch Clearing flags on attachment: 122072 Committed r104737: <http://trac.webkit.org/changeset/104737>
WebKit Review Bot
Comment 8 2012-01-11 13:12:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.