Bug 76062

Summary: Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, prybin, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72861    
Attachments:
Description Flags
Patch
none
InspectorFrontend.h base version
none
New InspectorFrontend.h none

Peter Rybin
Reported 2012-01-11 07:51:27 PST
Builder template classes use enum constants as their parameters. The enum constants should be named in CamelCase rather than in ALL_CAPS_WITH_UNDERSCORE.
Attachments
Patch (3.25 KB, patch)
2012-01-11 07:57 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
InspectorFrontend.h base version (143.42 KB, text/plain)
2012-01-11 08:01 PST, Peter Rybin 		no flags
Details
New InspectorFrontend.h (141.65 KB, text/plain)
2012-01-11 08:02 PST, Peter Rybin 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-01-11 07:57:02 PST
Created attachment 122023 [details] Patch
Peter Rybin
Comment 2 2012-01-11 08:01:31 PST
Created attachment 122024 [details] InspectorFrontend.h base version
Peter Rybin
Comment 3 2012-01-11 08:02:37 PST
Created attachment 122025 [details] New InspectorFrontend.h
WebKit Review Bot
Comment 4 2012-01-11 09:36:35 PST
Comment on attachment 122023 [details] Patch Clearing flags on attachment: 122023 Committed r104716: <http://trac.webkit.org/changeset/104716>
WebKit Review Bot
Comment 5 2012-01-11 09:36:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.