Bug 76056

Summary: Web Inspector: make setOuterHTML use new DOMEditor, cover it with tests.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2012-01-11 06:14:53 PST
Patch to follow.
Attachments
Patch (38.12 KB, patch)
2012-01-11 06:17 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-01-11 06:17:00 PST
Created attachment 122013 [details] Patch
Yury Semikhatsky
Comment 2 2012-01-11 07:44:02 PST
Comment on attachment 122013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122013&action=review > Source/WebCore/inspector/DOMEditor.cpp:55 > + Digest(Node* node) : m_node(node) { } missing explicit modifier > Source/WebCore/inspector/DOMEditor.cpp:114 > + *errorString = "DOMException: failed to set outer html."; Can you return DOM exception description here? > Source/WebCore/inspector/DOMEditor.cpp:162 > if (oldDigest->m_node->nodeType() != Node::ELEMENT_NODE) oldNode->nodeType() != Node::ELEMENT_NODE
Pavel Feldman
Comment 3 2012-01-11 08:18:35 PST
Committed r104713: <http://trac.webkit.org/changeset/104713>
Note You need to log in before you can comment on or make changes to this bug.