Bug 76056 - Web Inspector: make setOuterHTML use new DOMEditor, cover it with tests.
Summary: Web Inspector: make setOuterHTML use new DOMEditor, cover it with tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 06:14 PST by Pavel Feldman
Modified: 2012-01-11 08:18 PST (History)
10 users (show)

See Also:

Attachments
Patch (38.12 KB, patch)
2012-01-11 06:17 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-01-11 06:14:53 PST 
Patch to follow.
Comment 1 Pavel Feldman 2012-01-11 06:17:00 PST 
Created attachment 122013 [details]
Patch
Comment 2 Yury Semikhatsky 2012-01-11 07:44:02 PST 
Comment on attachment 122013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122013&action=review

> Source/WebCore/inspector/DOMEditor.cpp:55
> +    Digest(Node* node) : m_node(node) { }

missing explicit modifier

> Source/WebCore/inspector/DOMEditor.cpp:114
> +            *errorString = "DOMException: failed to set outer html.";

Can you return DOM exception description here?

> Source/WebCore/inspector/DOMEditor.cpp:162
>      if (oldDigest->m_node->nodeType() != Node::ELEMENT_NODE)

oldNode->nodeType() != Node::ELEMENT_NODE
Comment 3 Pavel Feldman 2012-01-11 08:18:35 PST 
Committed r104713: <http://trac.webkit.org/changeset/104713>